WIP: Make generated WoW talent keys type-safe #6

Draft
Codex Bot wants to merge 1 commits from fix/4-wow-talent-gate-types into fix/3-wow-gcd-categories
pull from: fix/4-wow-talent-gate-types

The generated legality Set inferred a narrow literal-union key and rejected the runtime string passed to .has during strict TypeScript checking. An explicit Set<string> type makes the gate type-safe; runtime membership and emitted JavaScript are unchanged.

Validation reproduces exactly one pre-fix TS2345 at the actual gate, then zero diagnostics with TypeScript 5.8.3. Three focused source tests and native cold/warm tests preserve 142 legal gates and three source-only exemptions. Both native engines are byte-identical before/after within their own checkout, and build reproducibility/bootstrap preflight pass. This is not a full web build, broader balance certification or new boss/GPU playtest.

Coordinator /root, session 01a11cd3-fa7c-7510-ba8f-bc7a3d0310a6. GPT-6 Luna/xhigh workers single_pass_source (annotation/doc), single_pass_validation (strict/runtime proof), single_pass_renderer (independent provenance audit). Root owns native integration, publication and separate Obsidian updates. Inputs/evidence are retained under Projects/Issue-Fixes/236-wow-talent-gate-types-2026-10-09. This draft is stacked on the previous category review and remains unmerged.

Tracks #4. Native integration: Codex/healer-man-godot#236. Scoped source release check passes.

The generated legality Set inferred a narrow literal-union key and rejected the runtime string passed to `.has` during strict TypeScript checking. An explicit `Set<string>` type makes the gate type-safe; runtime membership and emitted JavaScript are unchanged. Validation reproduces exactly one pre-fix TS2345 at the actual gate, then zero diagnostics with TypeScript 5.8.3. Three focused source tests and native cold/warm tests preserve 142 legal gates and three source-only exemptions. Both native engines are byte-identical before/after within their own checkout, and build reproducibility/bootstrap preflight pass. This is not a full web build, broader balance certification or new boss/GPU playtest. Coordinator /root, session 01a11cd3-fa7c-7510-ba8f-bc7a3d0310a6. GPT-6 Luna/xhigh workers single_pass_source (annotation/doc), single_pass_validation (strict/runtime proof), single_pass_renderer (independent provenance audit). Root owns native integration, publication and separate Obsidian updates. Inputs/evidence are retained under Projects/Issue-Fixes/236-wow-talent-gate-types-2026-10-09. This draft is stacked on the previous category review and remains unmerged. Tracks #4. Native integration: https://git.whoagland.com/Codex/healer-man-godot/issues/236. Scoped source release check passes.
Codex Bot added 1 commit 2026-10-09 15:41:58 -07:00
You are not authorized to merge this pull request.
This pull request can be merged automatically.
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/4-wow-talent-gate-types:fix/4-wow-talent-gate-types
git checkout fix/4-wow-talent-gate-types
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: phenom/healer-man#6