warren
3687c423e2
Coordinator Root /root, session 01a12399-cfab-7c72-8455-e0e4cb7e156c. Independently reviewed by /root/combat_source_finish_luna (GPT-6 Luna xhigh). 31 focused DK tests, required release check and complete source type check pass.
2.5 KiB
Death Pact and Blood Gorged finding corrections
Tracked in shared issue #19.
Coordinator: Root /root, session 01a12399-cfab-7c72-8455-e0e4cb7e156c.
The local Death Pact row (48743) supplies a 40% heal, a 100-yard minion-selection radius, a 40 runic-power cost, a 120-second cooldown and a 1.5-second GCD. Its hostile instant-kill conversion and tooltip-derived flat heal were wrong. The explicit sacrifice effect now consumes exactly one living, unexpired undead minion owned by the caster inside that radius and heals only that caster. The heal cannot crit. Missing minions fail before resource, cooldown or GCD use. Sacrifice produces a death record rather than damage-meter or experience credit. Player and companion dispatch share minion selection and death-state mutation.
The AzerothCore Death Pact handler corroborates living, owned undead selection within 100 yards and a single victim. This runtime admits only the two undead ghoul entries it already models through Raise Dead (26125) and Army of the Dead (24207). Unknown summon families are not assumed undead. Other undead minion types require a modeled source identity. Automated non-healer sacrifices use the existing defensive health threshold; this is simulator AI policy, not a spell-source trigger.
Blood Gorged's five local ranks contain only learn-spell effects (36), linking
the conditional damage and armor-penetration children. The catalog no longer
invents an active attack from that passive tooltip. Talent wrappers with only
learn effects and no activation cost, cast time or cooldown remain passive;
active and mixed-effect spells remain executable. The generator preserves the
same classification for future imports. Existing sourced Blood Gorged damage
and armor handling remains in wow335DeathKnightBloodGorgedRuntime.ts; see
docs/WOW_DEATH_KNIGHT_BLOOD_GORGED.md for its health and family-mask boundaries.
Focused validation covers real Raise Dead then Death Pact casts, hostile trash and bosses, owner isolation, dead/expired/distant/non-undead minions, exact cost/cooldown/GCD, overheal and noncritical event accounting, actual automatic companion dispatch, and all five Blood Gorged wrapper ranks. Existing player and companion Blood Gorged health/mask tests preserve the legitimate passive bonus. The historical 873-cell campaign and source snapshots are unchanged.