Release Healer Man 0.1.22

scripts/release_manager.py

@@ -75,6 +75,18 @@ class ReleaseVersion:
     version_code: int
 
 
+def full_release_checks(npm: str) -> tuple[tuple[list[str], str], ...]:
+    """Commands that must succeed before a release can be staged."""
+    return (
+        ([npm, "run", "content:test"], "Content tests"),
+        ([npm, "run", "server:test"], "Server tests"),
+        ([npm, "test"], "Application tests"),
+        ([npm, "run", "content:publish"], "Publish verified 54-dungeon content manifest"),
+        ([npm, "run", "build"], "Production build"),
+        ([npm, "run", "android:sync"], "Android web build and Capacitor sync"),
+    )
+
+
 def parse_semver(value: str) -> tuple[int, int, int]:
     match = SEMVER_PATTERN.fullmatch(value.strip())
     if not match:
@@ -239,11 +251,13 @@ def validate_release_candidates(project_root: Path = PROJECT_ROOT) -> list[str]:
                 cwd=project_root,
                 env=environment,
                 stdout=subprocess.PIPE,
-                stderr=subprocess.STDOUT,
+                stderr=subprocess.PIPE,
                 check=False,
             )
             if result.returncode != 0:
-                output = result.stdout.decode("utf-8", errors="replace").strip()
+                output = b"\n".join((result.stdout, result.stderr)).decode(
+                    "utf-8", errors="replace"
+                ).strip()
                 raise ReleaseError(
                     f"Release-candidate Git check failed ({result.returncode}): "
                     f"git {' '.join(args)}\n{output}"
@@ -269,11 +283,15 @@ def validate_release_candidates(project_root: Path = PROJECT_ROOT) -> list[str]:
             encoding="utf-8",
             errors="replace",
             stdout=subprocess.PIPE,
-            stderr=subprocess.STDOUT,
+            stderr=subprocess.PIPE,
             check=False,
         )
         if whitespace_result.returncode != 0:
-            detail = whitespace_result.stdout.strip()
+            detail = "\n".join(
+                part.strip()
+                for part in (whitespace_result.stdout, whitespace_result.stderr)
+                if part.strip()
+            )
             raise ReleaseError(
                 "Release-candidate whitespace check failed. This check includes "
                 f"tracked and untracked files:\n{detail}"
@@ -1096,14 +1114,7 @@ def launch_gui(*, smoke_test: bool = False) -> int:
                     f"Recorded Android version {version.version_name} / {version.version_code}."
                 )
 
-                checks = (
-                    ([npm, "run", "content:test"], "Content tests"),
-                    ([npm, "run", "server:test"], "Server tests"),
-                    ([npm, "test"], "Application tests"),
-                    ([npm, "run", "build"], "Production build"),
-                    ([npm, "run", "android:sync"], "Android web build and Capacitor sync"),
-                )
-                for command, label in checks:
+                for command, label in full_release_checks(npm):
                     self._run_command(command, label)
                 self._run_command(["git", "add", "-A"], "Stage release")
                 staged = True