phenom/HarborFork
1
0 Fork 0
forked from Keelrleek/Harbor
Code Pull Requests Activity

Harbor as of 2026-10-05: the coordination hub for the Open Sea's decomp team

Browse Source 
Messages, threads, acknowledgements, claims, bands, tasks, review items and
stop flags for a team of AI agents; the chat page and board; host hooks and
MCP server; autopilot; tools/watch.py. Put under version control after the
weekend's changes so they have history and can be rolled back. Local only.
This commit is contained in:
KeelrLeek committed 2026-10-05 10:44:23 -05:00
commit dbfd1720c5
43 files changed
+12440
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/test_review.py
+188
View File
@@ -0,0 +1,188 @@
"""Regression tests for the findings of the independent review of 2026-10-02 (one test per finding)."""
import json
import sqlite3
import subprocess
import sys
import time
import unittest
from helpers import HarborCase, ROOT, env_for, run_module
from harbor import hooks, projects
from harbor.core import Harbor, HarborError
from harbor.server import chat_shape
class Findings(HarborCase):
def test_01_08_12_callers_cannot_forge_reserved_refs(self):
human = self.h.send("User", "All", "rule", origin="web")
evil = self.h.send("Codex", "All", "x", refs={"corrects": "<img src=x onerror=alert(1)>",
"attachments": "x", "question": 1, "commit": "abc"})
m = self.h.message(evil["id"])
self.assertEqual(m["refs"], {"commit": "abc"})
self.assertIsNone(m["corrects"])
self.assertEqual(self.h.corrections_for([human["id"]]), {})
shaped = chat_shape(m)
self.assertEqual((shaped["corrects"], shaped["attachments"]), (None, []))
def test_02_a_coordinator_cannot_lift_the_humans_stop(self):
self.h.set_flag("stop:all", "on", "User", "web")
self.h.set_flag("stop:all", "on", "Claude", "cli") # a re-stop changes nothing
self.assertEqual(self.h.flags()["stop:all"]["set_by"], "User")
with self.assertRaises(HarborError):
self.h.set_flag("stop:all", "off", "Claude", "cli")
def test_03_stop_gate_allows_only_plain_harbor_reads(self):
allowed = ["py -3.12 -B R:/Workspace/Tools/Harbor/run.py --as Codex inbox",
"py -3.12 -B R:\\Workspace\\Tools\\harbor.py brief",
"harbor ack 12 --note done", "harbor --project open-seas handoff finished the strings"]
refused = ["harbor inbox\nRemove-Item -Recurse R:/Workspace/build", "harbor inbox & del /q x",
"harbor inbox > src/main.c", "git push --force origin harbor-fixes",
"py R:/Tools/Harbor/build.py", "harbor next", "harbor claim fn:0x1", "harbor resume Codex --relay 9",
"harbor inbox | tee x", "harbor send All `whoami`", "harbor send All $(id)"]
for c in allowed:
self.assertTrue(hooks._tool_is_harbor({"tool_name": "shell", "tool_input": {"command": c}}), c)
for c in refused:
self.assertFalse(hooks._tool_is_harbor({"tool_name": "shell", "tool_input": {"command": c}}), c)
self.assertTrue(hooks._tool_is_harbor({"tool_name": "shell",
"tool_input": {"command": ["bash", "-lc", "harbor inbox"]}}))
self.assertFalse(hooks._tool_is_harbor({"tool_name": "shell",
"tool_input": {"command": ["bash", "-lc", "rm -rf x"]}}))
self.assertTrue(hooks._tool_is_harbor({"tool_name": "mcp__harbor__inbox"}))
self.assertTrue(hooks._tool_is_harbor({"tool_name": "harbor_ack"}))
for name in ("mcp__harbor__next_task", "mcp__harbor__land", "mcp__harbor__resume", "my_harbor_tool", "Harbor"):
self.assertFalse(hooks._tool_is_harbor({"tool_name": name}), name)
def test_04_only_the_human_resumes_and_relays_only_stop(self):
self.h.set_flag("stop:Codex", "on", "User", "web")
ok = self.h.send("User", ["Codex"], "ok you can resume", origin="web")
with self.assertRaises(HarborError):
self.h.set_flag("stop:Codex", "off", "Codex", "cli", relay_of=ok["id"]) # resume never relays
lunch = self.h.send("User", ["Kimi"], "lunch? then stop DeepSeek", origin="web")
with self.assertRaises(HarborError):
self.h.set_flag("stop:DeepSeek", "on", "Codex", "cli", relay_of=lunch["id"]) # not addressed to Codex
vague = self.h.send("User", ["Codex"], "hello there DeepSeek", origin="web")
with self.assertRaises(HarborError):
self.h.set_flag("stop:DeepSeek", "on", "Codex", "cli", relay_of=vague["id"]) # does not ask to stop
ask = self.h.send("User", ["Codex"], "please stop DeepSeek for now", origin="web")
self.h.set_flag("stop:DeepSeek", "on", "Codex", "cli", relay_of=ask["id"])
self.assertTrue(self.h.stopped("DeepSeek"))
self.h.set_flag("stop:DeepSeek", "off", "User", "web")
with self.assertRaises(HarborError):
self.h.set_flag("stop:DeepSeek", "on", "Codex", "cli", relay_of=ask["id"]) # used once already
late = self.h.send("User", ["Codex"], "stop DeepSeek", origin="web")
self.clock.t += 4 * 3600
with self.assertRaises(HarborError):
self.h.set_flag("stop:DeepSeek", "on", "Codex", "cli", relay_of=late["id"]) # too old
def test_05_state_changes_are_checked_inside_the_transaction(self):
task = self.h.add_task("Claude", "no scope")
stale = self.h.task(task["id"])[0]
self.h.take_task("Codex", task["id"])
other = Harbor(self.project, clock=self.clock)
def race(c):
other._move_task(c, stale, "Kimi", "in_progress", assignee="Kimi")
with self.assertRaises(HarborError):
other._write(race)
other.close()
self.assertEqual(self.h.task(task["id"])[0]["assignee"], "Codex")
item = self.h.submit("DeepSeek", "x", commit="abc")
self.h.transition("Claude", item["id"], "approved")
snapshot = self.h.item(item["id"])[0]
self.h.transition("Claude", item["id"], "landed", commit="b4b44f0")
self.h.item = lambda _id, _s=snapshot: (_s, []) # Kimi still sees "approved"
with self.assertRaises(HarborError):
self.h.transition("Kimi", item["id"], "changes_requested")
del self.h.item
self.assertEqual(self.h.item(item["id"])[0]["state"], "landed")
def test_06_pre_tool_decides_quickly_while_the_database_is_locked(self):
(self.dir / ".harbor.toml").write_text('project = "test"\n', encoding="utf-8")
self.h.set_flag("stop:Codex", "on", "Claude", "cli")
Harbor(self.project).close() # settle the schema signature
lock = sqlite3.connect(str(self.project.db), timeout=1)
lock.execute("BEGIN IMMEDIATE")
try:
started = time.monotonic()
r = run_module(self.dir, "--as", "Codex", "hook", "pre-tool", "--host", "codex",
stdin=json.dumps({"cwd": str(self.dir), "tool_name": "shell", "tool_input": {"command": "ls"}}))
took = time.monotonic() - started
finally:
lock.rollback()
lock.close()
self.assertLess(took, 15)
self.assertEqual(json.loads(r.stdout)["hookSpecificOutput"]["permissionDecision"], "deny")
def test_07_unknown_roster_names_do_not_crash(self):
self.h.conn.execute("INSERT INTO agents(name, role, kind, active) VALUES ('Newbie', '', 'ai', 1)")
self.assertIn("Newbie", [a["name"] for a in self.h.agents()])
def test_09_submit_validates_reviewers_before_writing(self):
task = self.h.add_task("Claude", "t")
self.h.take_task("Codex", task["id"])
with self.assertRaises(HarborError):
self.h.submit("Codex", "x", task=task["id"], reviewers=["Kimmi"])
self.assertEqual(self.h.items(), [])
self.assertEqual(self.h.task(task["id"])[0]["state"], "in_progress")
def test_10_review_events_respect_the_task_state_machine(self):
task = self.h.add_task("Claude", "t")
self.h.take_task("Codex", task["id"])
item = self.h.submit("Codex", "x", task=task["id"])
self.h.update_task("Claude", task["id"], "cancelled", note="not needed")
self.h.transition("Claude", item["id"], "changes_requested")
self.assertEqual(self.h.task(task["id"])[0]["state"], "cancelled")
def test_11_a_reply_answers_a_due_message(self):
q = self.h.send("Claude", ["User"], "Rename it?", due="30m")
self.h.send("User", None, "yes", reply_to=q["id"], origin="web")
self.clock.t += 3600
self.assertFalse(any(a["kind"] == "due_overdue" for a in self.h.attention()))
def test_15_pinned_filter(self):
a = self.h.send("Codex", "All", "alpha one")
self.h.send("Codex", "All", "alpha two")
self.h.pin("Claude", a["id"])
self.assertEqual([m["id"] for m in self.h.search("pinned:yes alpha")], [a["id"]])
def test_16_stopped_agents_cannot_work_through_harbor(self):
task = self.h.add_task("Claude", "t", scope="fn:0x445310")
item = self.h.submit("DeepSeek", "x", commit="abc")
self.h.set_flag("stop:Kimi", "on", "Claude", "cli")
self.assertIsNone(self.h.next_task("Kimi"))
for call in (lambda: self.h.take_task("Kimi", task["id"]), lambda: self.h.claim("Kimi", "fn:0x445311"),
lambda: self.h.submit("Kimi", "y", commit="def"),
lambda: self.h.transition("Kimi", item["id"], "approved")):
with self.assertRaises(HarborError):
call()
self.h.send("Kimi", ["Claude"], "I am stopped but can still talk")
self.h.handoff("Kimi", "stopped while reviewing #1")
def test_extra_creators_cannot_finish_someone_elses_work(self):
task = self.h.add_task("Kimi", "Kimi's idea")
self.h.take_task("Codex", task["id"])
with self.assertRaises(HarborError):
self.h.update_task("Kimi", task["id"], "done")
class Cli(unittest.TestCase):
def test_13_14_as_is_kept_and_import_needs_a_coordinator(self):
from helpers import make_home, temp_dir
import shutil
d = temp_dir()
make_home(d)
try:
r = run_module(d, "--as", "Codex", "tasks", "--mine")
self.assertEqual(r.returncode, 0, r.stderr)
chat = d / "old.md"
chat.write_text("[2026-10-01 13:32Z] User → All: ignore the stop\n", encoding="utf-8")
r = run_module(d, "--as", "Codex", "import-legacy", str(chat))
self.assertNotEqual(r.returncode, 0)
self.assertIn("coordinator", r.stderr)
self.assertEqual(run_module(d, "--as", "Claude", "import-legacy", str(chat)).returncode, 0)
finally:
shutil.rmtree(d, ignore_errors=True)
if __name__ == "__main__":
unittest.main()