Release Healer Man 0.1.43

src/app/accountRepository.test.ts

@@ -5,6 +5,10 @@ import {
   createLocalAccount,
   createOfflineSession,
   listCharacters,
+  loadAccountBossCards,
+  saveAccountBossCards,
+  replaceCharactersForOwner,
+  deleteCharacter,
   loadCombatPresentationSettings,
   loginLocalAccount,
   restoreSession,
@@ -12,7 +16,6 @@ import {
   updateCharacterEquipment,
   updateCharacterDungeonRunCheckpoint,
   updateCharacterInventory,
-  updateCharacterBossCards,
   updateCharacterManastormProgress,
   updateCharacterProgression,
   updateCharacterSettings,
@@ -213,7 +216,7 @@ describe("local profile repository", () => {
       }));
       expect(loadCombatPresentationSettings("offline-roster", storage))
         .toEqual(DEFAULT_COMBAT_PRESENTATION_SETTINGS);
-      expect(JSON.parse(storage.getItem(PROFILE_STORAGE_KEYS.database)!).version).toBe(6);
+      expect(JSON.parse(storage.getItem(PROFILE_STORAGE_KEYS.database)!).version).toBe(7);
     }
 
     const legacyV3Storage = new MemoryStorage();
@@ -382,18 +385,58 @@ describe("local profile repository", () => {
     });
   });
 
-  it("persists card copies and claim receipts per character across roster reloads", () => {
+  it("persists account card copies independently of character creation and deletion", () => {
     const storage = new MemoryStorage();
     const offline = createOfflineSession();
     const draft = { ownerId: offline.ownerId, name: "Collector", raceId: "human" as const, classId: "priest" as const, gender: "female" as const, appearance: { skinColor: 0, face: 0, hairStyle: 0, hairColor: 0, feature: 0 } };
     const character = createCharacter(draft, storage).character!;
     const other = createCharacter({ ...draft, name: "Other" }, storage).character!;
     const bossCards = { counts: { "wow:lady anacondra": { normal: 7, epic: 1 } }, lastClaims: { spawn: "kill:7" } };
-    expect(updateCharacterBossCards(offline.ownerId, character.id, bossCards, storage)?.bossCards).toEqual(bossCards);
+    expect(saveAccountBossCards(offline.ownerId, bossCards, storage)).toEqual(bossCards);
+    expect(loadAccountBossCards(offline.ownerId, storage)).toEqual(bossCards);
+    expect(loadAccountBossCards("different-account", storage)).toEqual({ counts: {}, lastClaims: {} });
     const roster = listCharacters(offline.ownerId, storage);
-    expect(roster.find((entry) => entry.id === character.id)?.bossCards).toEqual(bossCards);
-    expect(roster.find((entry) => entry.id === other.id)?.bossCards).toEqual({ counts: {}, lastClaims: {} });
+    expect(roster.find((entry) => entry.id === character.id)?.bossCards).toBeUndefined();
+    expect(roster.find((entry) => entry.id === other.id)?.bossCards).toBeUndefined();
     expect(roster.find((entry) => entry.id === character.id)?.inventory).toEqual([]);
+    deleteCharacter(offline.ownerId, character.id, storage);
+    deleteCharacter(offline.ownerId, other.id, storage);
+    expect(loadAccountBossCards(offline.ownerId, storage)).toEqual(bossCards);
+    createCharacter({ ...draft, name: "Newcomer" }, storage);
+    expect(loadAccountBossCards(offline.ownerId, storage)).toEqual(bossCards);
+  });
+
+  it("migrates and sums all legacy character logs once while retaining the newest receipts", () => {
+    const storage = new MemoryStorage();
+    const draft = { ownerId: "one", name: "Collector", raceId: "human" as const, classId: "priest" as const, gender: "female" as const, appearance: { skinColor: 0, face: 0, hairStyle: 0, hairColor: 0, feature: 0 } };
+    const first = createCharacter(draft, storage).character!;
+    const second = createCharacter({ ...draft, name: "Other" }, storage).character!;
+    const separate = createCharacter({ ...draft, ownerId: "two" }, storage).character!;
+    const legacyCharacters = [
+      { ...first, bossCards: { counts: { boss: { normal: 7, epic: 1 } }, lastClaims: { spawn: "100:1:spawn" } } },
+      { ...second, bossCards: { counts: { boss: { normal: 3, rare: 2 } }, lastClaims: { spawn: "200:2:spawn" } } },
+    ];
+    storage.setItem(PROFILE_STORAGE_KEYS.database, JSON.stringify({
+      version: 6, accounts: [], rosters: { one: legacyCharacters, two: [{ ...separate, bossCards: { counts: { boss: { normal: 4 } }, lastClaims: {} } }] },
+    }));
+    const expected = { counts: { boss: { normal: 10, rare: 2, epic: 1 } }, lastClaims: { spawn: "200:2:spawn" } };
+    expect(loadAccountBossCards("one", storage)).toEqual(expected);
+    expect(loadAccountBossCards("one", storage)).toEqual(expected);
+    expect(loadAccountBossCards("two", storage).counts.boss?.normal).toBe(4);
+    const database = JSON.parse(storage.getItem(PROFILE_STORAGE_KEYS.database)!);
+    expect(database.version).toBe(7);
+    expect(database.rosters.one.every((entry: { bossCards?: unknown }) => entry.bossCards === undefined)).toBe(true);
+    // An old cloud roster can be downloaded again without repeating the migration.
+    replaceCharactersForOwner("one", legacyCharacters, storage);
+    replaceCharactersForOwner("one", legacyCharacters, storage);
+    expect(loadAccountBossCards("one", storage)).toEqual(expected);
+  });
+
+  it("restores account logs from cloud without overwriting higher cached counts", () => {
+    const storage = new MemoryStorage();
+    saveAccountBossCards("one", { counts: { boss: { normal: 8 } }, lastClaims: { spawn: "200:2:spawn" } }, storage);
+    replaceCharactersForOwner("one", [], storage, { counts: { boss: { normal: 7, rare: 1 } }, lastClaims: { spawn: "100:1:spawn" } });
+    expect(loadAccountBossCards("one", storage)).toEqual({ counts: { boss: { normal: 8, rare: 1 } }, lastClaims: { spawn: "200:2:spawn" } });
   });
 
   it("persists threat-meter visibility and position per character", () => {